adoroszlai commented on a change in pull request #91: HDDS-2361. Ozone Manager
init & start command prints out unnecessary line in the beginning.
URL: https://github.com/apache/hadoop-ozone/pull/91#discussion_r339290099
##########
File path: hadoop-ozone/common/src/main/shellprofile.d/hadoop-ozone-manager.sh
##########
@@ -19,8 +19,10 @@ if [[ "${HADOOP_SHELL_EXECNAME}" == ozone ]]; then
fi
_ozone_manager_hadoop_finalize() {
- if [[ "${HADOOP_CLASSNAME}" ==
"org.apache.hadoop.ozone.om.OzoneManagerStarter" ]]; then
- echo "Ozone Manager classpath extended by ${OZONE_MANAGER_CLASSPATH}"
- hadoop_add_classpath "${OZONE_MANAGER_CLASSPATH}"
+ if [[ "${HADOOP_CLASSNAME}" ==
"org.apache.hadoop.ozone.om.OzoneManagerStarter" ]] &
Review comment:
Single `&` starts the command in the background. Please use `&&` instead.
```suggestion
if [[ "${HADOOP_CLASSNAME}" ==
"org.apache.hadoop.ozone.om.OzoneManagerStarter" ]] &&
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
