Lisheng Sun created HDFS-14994: ---------------------------------- Summary: Optimize LowRedundancyBlocks#chooseLowRedundancyBlocks() Key: HDFS-14994 URL: https://issues.apache.org/jira/browse/HDFS-14994 Project: Hadoop HDFS Issue Type: Improvement Reporter: Lisheng Sun
when priority=QUEUE_WITH_CORRUPT_BLOCKS, it mean no block in needreplication need replica. in current code if use continue, there is one more invalid judgment (priority ==QUEUE_WITH_CORRUPT_BLOCKS). i think it should use break instread of continue. {code:java} */ synchronized List<List<BlockInfo>> chooseLowRedundancyBlocks( int blocksToProcess) { final List<List<BlockInfo>> blocksToReconstruct = new ArrayList<>(LEVEL); int count = 0; int priority = 0; for (; count < blocksToProcess && priority < LEVEL; priority++) { if (priority == QUEUE_WITH_CORRUPT_BLOCKS) { // do not choose corrupted blocks. continue; } ... } {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org