Xuze Yang created HDFS-15990: -------------------------------- Summary: No need to write to sub_section when serialize SnapshotDiff Section Key: HDFS-15990 URL: https://issues.apache.org/jira/browse/HDFS-15990 Project: Hadoop HDFS Issue Type: Bug Components: hdfs Affects Versions: 2.10.0 Reporter: Xuze Yang
In FSImageFormatPBSnapshot.serializeSnapshotDiffSection(), the following code exists: {quote}if (i % parent.getInodesPerSubSection() == 0) { parent.commitSubSection(headers, FSImageFormatProtobuf.SectionName.SNAPSHOT_DIFF_SUB); } {quote} It aims to serialize SnapshotDiff information into several sub_sections(i.e. additional sub_sections information will be written to FileSummary Section). But in FSImageFormatPBSnapshot.loadSnapshotDiffSection(), it treats SnapshotDiffSection as a whole, rather than several sub_sections. So it's no need to introduce sub_sections here. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org