JiangHua Zhu created HDFS-16118:
-----------------------------------

             Summary: Improve the number of handlers that initialize 
NameNodeRpcServer#clientRpcServer
                 Key: HDFS-16118
                 URL: https://issues.apache.org/jira/browse/HDFS-16118
             Project: Hadoop HDFS
          Issue Type: Improvement
            Reporter: JiangHua Zhu


When initializing NameNodeRpcServer, if the value of 
dfs.namenode.lifeline.handler.count is set to be less than 0 (such as -1, of 
course, this is rare), when determining the number of lifeline RPC handlers, it 
will be based on dfs.namenode.handler .count * lifelineHandlerRatio is 
determined.
The code can be found:
int lifelineHandlerCount = conf.getInt(
           DFS_NAMENODE_LIFELINE_HANDLER_COUNT_KEY, 0);
       if (lifelineHandlerCount <= 0) {
         float lifelineHandlerRatio = conf.getFloat(
             DFS_NAMENODE_LIFELINE_HANDLER_RATIO_KEY,
             DFS_NAMENODE_LIFELINE_HANDLER_RATIO_DEFAULT);
         lifelineHandlerCount = Math.max(
             (int)(handlerCount * lifelineHandlerRatio), 1);
       }
When this happens, the handlerCount should be subtracted from the 
lifelineHandlerCount when in fact it doesn't.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org

Reply via email to