ZhangHB created HDFS-16909:
------------------------------
Summary: Make judging null statment out from for loop in
ReplicaMap#mergeAll method.
Key: HDFS-16909
URL: https://issues.apache.org/jira/browse/HDFS-16909
Project: Hadoop HDFS
Issue Type: Improvement
Components: datanode
Affects Versions: 3.3.4
Reporter: ZhangHB
Currently, the code is as below:
{code:java}
for (ReplicaInfo replicaInfo : replicaSet) {
checkBlock(replicaInfo);
if (curSet == null) {
// Add an entry for block pool if it does not exist already
curSet = new LightWeightResizableGSet<>();
map.put(bp, curSet);
}
curSet.put(replicaInfo);
} {code}
the statment :
{code:java}
if(curSet == null){code}
should be moved to outside from the for loop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
