[ https://issues.apache.org/jira/browse/HDFS-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732841#action_12732841 ]
Hadoop QA commented on HDFS-492: -------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12413885/hdfs-492-4.patch against trunk revision 794953. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs warnings. -1 release audit. The applied patch generated 283 release audit warnings (more than the trunk's current 282 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/24/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/24/artifact/trunk/current/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/24/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/24/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/24/console This message is automatically generated. > Expose corrupt replica/block information > ---------------------------------------- > > Key: HDFS-492 > URL: https://issues.apache.org/jira/browse/HDFS-492 > Project: Hadoop HDFS > Issue Type: New Feature > Components: data-node, name-node > Affects Versions: 0.21.0 > Reporter: Bill Zeller > Priority: Minor > Attachments: hdfs-492-4.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > This adds two additional functions to FSNamesystem to provide more > information about corrupt replicas. It also adds two servlets to the namenode > that provide information (in JSON) about all blocks with corrupt replicas as > well as information about a specific block. It also changes the file browsing > servlet by adding a link from block ids to the above mentioned block > information page. > These JSON pages are designed to be used by client side tools which wish to > analyze corrupt block/replicas. The only change to an existing (non-servlet) > class is described below. > Currently, CorruptReplicasMap stores a map of corrupt replica information and > allows insertion and deletion. It also gives information about the corrupt > replicas for a specific block. It does not allow iteration over all corrupt > blocks. Two additional functions will be added to FSNamesystem (which will > call BlockManager which will call CorruptReplicasMap). The first will return > the size of the corrupt replicas map, which represents the number of blocks > that have corrupt replicas (but less than the number of corrupt replicas if a > block has multiple corrupt replicas). The second will allow "paging" through > a list of block ids that contain corrupt replicas: > {{public synchronized List<Long> getCorruptReplicaBlockIds(int n, Long > startingBlockId)}} > {{n}} is the number of block ids to return and {{startingBlockId}} is the > block id offset. To prevent a large number of items being returned at one > time, n is constrained to 0 <= {{n}} <= 100. If {{startingBlockId}} is null, > up to {{n}} items are returned starting at the beginning of the list. > Ordering is enforced through the internal use of TreeMap in > CorruptReplicasMap. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.