[ https://issues.apache.org/jira/browse/HDFS-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-501: ---------------------------------------- Attachment: h501_20090724b.patch h501_20090724b.patch: incorporated Suresh's comments and cleaned up some codes. {noformat} [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 12 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. {noformat} > Use enum to define the constants in DataTransferProtocol > -------------------------------------------------------- > > Key: HDFS-501 > URL: https://issues.apache.org/jira/browse/HDFS-501 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Attachments: h501_20090724.patch, h501_20090724b.patch > > > There are quite a few integer (int/byte) constants defined in > DataTransferProtocol. It is better to replace them by enums. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.