[
https://issues.apache.org/jira/browse/HDFS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736404#action_12736404
]
Konstantin Shvachko commented on HDFS-119:
------------------------------------------
# You do not need to enclose {{processIOError()}} in synchronized section,
because it is already synchronized.
# {{getEditsStream()}} is declared public. Could you please make it package
private.
# could you please do the same for {{getStorage()}}.
# {{listEditsStreams()}} is not used anywhere. Can we just remove it instead of
synchronizing.
> logSync() may block NameNode forever.
> -------------------------------------
>
> Key: HDFS-119
> URL: https://issues.apache.org/jira/browse/HDFS-119
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Konstantin Shvachko
> Attachments: HDFS-119.patch
>
>
> # {{FSEditLog.logSync()}} first waits until {{isSyncRunning}} is false and
> then performs syncing to file streams by calling
> {{EditLogOutputStream.flush()}}.
> If an exception is thrown after {{isSyncRunning}} is set to {{true}} all
> threads will always wait on this condition.
> An {{IOException}} may be thrown by {{EditLogOutputStream.setReadyToFlush()}}
> or a {{RuntimeException}} may be thrown by {{EditLogOutputStream.flush()}} or
> by {{processIOError()}}.
> # The loop that calls {{eStream.flush()}} for multiple
> {{EditLogOutputStream}}-s is not synchronized, which means that another
> thread may encounter an error and modify {{editStreams}} by say calling
> {{processIOError()}}. Then the iterating process in {{logSync()}} will break
> with {{IndexOutOfBoundException}}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
