[
https://issues.apache.org/jira/browse/HDFS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737676#action_12737676
]
Konstantin Boudnik commented on HDFS-124:
-----------------------------------------
I love the fact that it has a performance test now - it seems like a yet
another brick to the performance wall being build!
A couple of quick comments:
- Hadoop is using JUnit4.5 right now. However, I'm seeing new tests coming in
using old JUnit3 notations. E.g. TestCase extensions, junit.framework.* etc.
Shall we start using org.junit.* instead and use
{noformat}
@Test
{noformat}
annotation instead of direct inheritance from TestCase superclass? Annotations
should let us use arbitrary test names as well.
- for future use I'd suggest to put additional tags to the JavaDoc of
performanceTestDeleteSameFile. Say
{noformat}
+ * PerformanceTestSuite
{noformat}
so later on we'd be able to find all such tests at once to include them into
performance suite whenever it will be created?
> Namenode slowed down when many files with same filename were moved to Trash
> ---------------------------------------------------------------------------
>
> Key: HDFS-124
> URL: https://issues.apache.org/jira/browse/HDFS-124
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Koji Noguchi
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: COMMON-124.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
