[ https://issues.apache.org/jira/browse/HDFS-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740790#action_12740790 ]
Hairong Kuang commented on HDFS-509: ------------------------------------ Thanks Konstantin and Suresh for their detailed comments.I've already discussed with Suresh in person regarding his comments and will incorporate most of his suggestions. > ReplicaBeingWritten has a list of threads in your patch. I do not understand > whether you want to let multiple clients write to the same replica. Why do we > need that? This is the legacy code and I will change this when I work on the pipeline. For this issue I do not want to change any of the write logic code. I am still debating on the replica class hierarchy. I feel that using the state flay is quite error-prone. Would the following hierarchy provide a good tradeoff, clean but not too complicated. This design removes all interfaces defined in the previous patch. Block ReplicaInfo FinalizedReplica ReplicaWaitingToBeRecovered ReplicaUnderRecovery ReplicaInPipeline ReplicaBeingWritten TemporaryReplica > Redesisn DataNode volumeMap to include all types of Replicas > ------------------------------------------------------------ > > Key: HDFS-509 > URL: https://issues.apache.org/jira/browse/HDFS-509 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: data-node > Affects Versions: Append Branch > Reporter: Hairong Kuang > Assignee: Hairong Kuang > Fix For: Append Branch > > Attachments: replicas.patch > > > With the new append design, replicas at a DataNode could be in one of the > five states: Finalized, ReplicaBeingWritten, ReplicaWaitingToBeRecovered, > ReplicaUnderRecovery, and Temporay. This jira is to > 1. define the in-memory representation of these five types of replicas > 2. redefine volumeMap to include all five types of replicas and remove > ongoingCreates map. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.