[ https://issues.apache.org/jira/browse/HDFS-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746252#action_12746252 ]
Chris Douglas commented on HDFS-538: ------------------------------------ (after applying HADOOP-6201 ) {noformat} [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. {noformat} > DistributedFileSystem::listStatus incorrectly returns null for empty result > sets > -------------------------------------------------------------------------------- > > Key: HDFS-538 > URL: https://issues.apache.org/jira/browse/HDFS-538 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Jakob Homan > Assignee: Jakob Homan > Attachments: HDFS-538.patch > > > Currently the listStatus method returns null if no files match the request. > This differs from the Checksum/LocalFileSystem implementation, which returns > an empty array, and the nontvery-explict prescription of the FileSystem > interface: "{...@return the statuses of the files/directories in the given > patch}}" It's better to return an empty collection than have to add extra > null checks. The method should return an empty array. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.