[ 
https://issues.apache.org/jira/browse/HDFS-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746322#action_12746322
 ] 

Konstantin Shvachko commented on HDFS-544:
------------------------------------------

# In DataStorage.linkAllBlocks() you commented our the {{toDir.mkdir()}} part. 
You probably wanted to remove it.
# I would avoid all spelling, formatting, commenting, empty line changes, 
because they will make merging hard.
# Don't think introducing {{FINALIZED_DIR_NAME}} in {{MiniDFSCluster}} is a 
good idea. It is better than what we have now - a plain string {{current}}. 
{{DataStorage}} is a public class, we should rather add a public static method 
to it {{getFinalizedDirectoryName()}}. Then "finalized" will defined only in 
one place.

> Add a "rbw" sub directory to DataNode data directory
> ----------------------------------------------------
>
>                 Key: HDFS-544
>                 URL: https://issues.apache.org/jira/browse/HDFS-544
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node
>    Affects Versions: Append Branch
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: Append Branch
>
>         Attachments: datanodeOnDiskLayout.patch, datanodeOnDiskLayout1.patch
>
>
> Add a "rbw" sub directory to DataNode to persist RBW, RWR, and RUR replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to