[
https://issues.apache.org/jira/browse/HDFS-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo (Nicholas), SZE updated HDFS-563:
----------------------------------------
Attachment: h563_20090825.patch
h563_20090825.patch:
> I am not sure how useful the addition of Util.getBlockLocations() is. ...
The idea is to remove some public methods which are used for unit tests.
> In order to establish the right precedence it would be better to change
> parameter FSNamesystem to NameNode in Util.getBlockLocations(). That way we
> will be able to make getNamesystem() method package private down the road.
Changed the parameter from FSNamesystem to NameNode. Also changed
NameNode.getNamesystem() method package private.
> May I suggest to rename the class to something like AccessWrappers because it
> is likely that we are going to see more like these in the feature.
Renamed Util to AccessWrappers.
Thanks Suresh, Konstantin and Cos for all the review comments.
> Simplify the codes in FSNamesystem.getBlockLocations(..)
> --------------------------------------------------------
>
> Key: HDFS-563
> URL: https://issues.apache.org/jira/browse/HDFS-563
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: h563_20090821.patch, h563_20090825.patch
>
>
> There are un-used codes in FSNamesystem.getBlockLocations(..). Also, some
> codes can be moved to tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
