[ https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748869#action_12748869 ]
Hadoop QA commented on HDFS-456: -------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12417979/HDFS-456.patch against trunk revision 808670. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 148 release audit warnings (more than the trunk's current 147 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/99/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/99/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/99/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/99/console This message is automatically generated. > Problems with dfs.name.edits.dirs as URI > ---------------------------------------- > > Key: HDFS-456 > URL: https://issues.apache.org/jira/browse/HDFS-456 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.21.0 > Reporter: Konstantin Shvachko > Assignee: Luca Telloli > Fix For: 0.21.0 > > Attachments: failing-tests.zip, HDFS-456.patch, HDFS-456.patch, > HDFS-456.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch, HDFS-456.patch > > > There are several problems with recent commit of HDFS-396. > # It does not work with default configuration "file:///". Throws > {{IllegalArgumentException}}. > # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an > illegal URI. Backward compatibility is not provided. > # {{IllegalArgumentException}} should not be thrown within hdfs code because > it is a {{RuntimException}}. We should throw {{IOException}} instead. This > was recently discussed in another jira. > # Why do we commit patches without running unit tests and test-patch? This is > the minimum requirement for a patch to qualify as committable, right? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.