[
https://issues.apache.org/jira/browse/HDFS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750591#action_12750591
]
Konstantin Shvachko commented on HDFS-565:
------------------------------------------
N> Also, did you run "ant test-patch"?
Sure I did.
H> When complete a file, the last block should be committed before progress
check, but the penultimate block should not be completed until progress check
is passed.
I agree. Actually, the same should apply in both cases for completeBlock() and
for getAdditionalBlock().
Thanks for the patch, Konstantin.
I'll create a new jira to fix the issues.
> Introduce block committing logic during new block allocation and file close.
> ----------------------------------------------------------------------------
>
> Key: HDFS-565
> URL: https://issues.apache.org/jira/browse/HDFS-565
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs client, name-node
> Affects Versions: Append Branch
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: Append Branch
>
> Attachments: CommitBlock.patch, CommitBlock.patch, HDFS-565.aj.patch
>
>
> {{ClientProtocol}} methods {{addBlock()}} and {{complete()}} need to include
> additional parameter - a block, which has been successfully written to
> data-nodes. By sending this block to the name-node the client confirms the
> generation stamp of the block and its length. The block on the name-node
> changes its state to committed and will become complete as long as one of the
> finalized replicas reported by data-nodes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
