[
https://issues.apache.org/jira/browse/HDFS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750657#action_12750657
]
Konstantin Shvachko commented on HDFS-570:
------------------------------------------
> Could you explain more?
As I said before, you mix in your patch changes related to the current jira
with unrelated refactoring of the code.
I listed most of the cases (1-8) that do not belong to the functionality you
are implementing.
And which
# Obscure understanding of the new functionality you actually introduce.
# Make it hard to continue merging the trunk with the branch.
My proposal is to separate the implementation of the visible length from the
refactoring of the code into 2 separate patches.
The refactoring should be applied then to the trunk and to the branch.
My personal preference is to postpone the refactoring until append is merged to
the trunk.
> 5. Why do you need to abstract getReplicaInfo()? It does not seem that
> SimulatedFSDataset actually need it anywhere, at least not yet.
> FSDatasetInterface is an interface. By definition, all methods in an
> interface must be abstract.
getReplicaInfo() is currently a private method of FSDataset. You are adding it
to FSDatasetInterface. Based on the usage of the method I don't see a need for
that.
> When opening a file for read, make the file length avaliable to client.
> -----------------------------------------------------------------------
>
> Key: HDFS-570
> URL: https://issues.apache.org/jira/browse/HDFS-570
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs client
> Affects Versions: Append Branch
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: Append Branch
>
> Attachments: h570_20090828.patch
>
>
> In order to support read consistency, DFSClient needs the file length at the
> file opening time. In the current implmentation, DFSClient obtains the file
> length at the file opening time but the length is inaccurate if the file is
> being written.
> For more details, see Section 4 in the [append design
> doc|https://issues.apache.org/jira/secure/attachment/12415768/appendDesign2.pdf].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
