[ 
https://issues.apache.org/jira/browse/HDFS-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753239#action_12753239
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-603:
---------------------------------------------

{noformat}
     [exec] +1 overall.
     [exec]
     [exec] +1 @author. The patch does not contain any @author tags.
     [exec]
     [exec] +1 tests included. The patch appears to include 6 new or modified 
tests.
     [exec]
     [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
     [exec]
     [exec] +1 javac. The applied patch does not increase the total number of 
javac compiler warnings.
     [exec]
     [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec] +1 release audit. The applied patch does not increase the total 
number of release audit warnings.
{noformat}
Passed all the tests this time. Note that the patch does not fix TestBackupNode.

> Most replica related classes cannot be accessed
> -----------------------------------------------
>
>                 Key: HDFS-603
>                 URL: https://issues.apache.org/jira/browse/HDFS-603
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: Append Branch
>            Reporter: Tsz Wo (Nicholas), SZE
>             Fix For: Append Branch
>
>         Attachments: h603_20090908.patch, h603_20090909.patch
>
>
> Currently, there are several replica related classes in 
> org.apache.hadoop.hdfs.server.datanode:
> - ReplicaInfo
> - ReplicaInPipelineInterface
> - ReplicaInPipeline
> - ReplicaUnderRecovery
> - ReplicaWaitingToBeRecovered
> - ReplicaBeingWritten
> - FinalizedReplica
> All these classes cannot be accessed above FSDatasetInterface.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to