[ https://issues.apache.org/jira/browse/HDFS-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757599#action_12757599 ]
Hadoop QA commented on HDFS-629: -------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420067/war.txt against trunk revision 816785. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/console This message is automatically generated. > Remove ReplicationTargetChooser.java along with fixing import warnings. > ----------------------------------------------------------------------- > > Key: HDFS-629 > URL: https://issues.apache.org/jira/browse/HDFS-629 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.21.0 > Reporter: Konstantin Shvachko > Assignee: dhruba borthakur > Fix For: 0.21.0 > > Attachments: war.txt > > > ReplicationTargetChooser.java is empty and should be removed. > This is introduced by pluggable replica placement interface HDFS-385 along > with some import warnings in: > BlockPlacementPolicy > BlockPlacementPolicyDefault -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.