[ 
https://issues.apache.org/jira/browse/HDFS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763591#action_12763591
 ] 

Konstantin Boudnik commented on HDFS-669:
-----------------------------------------

Seems interesting! 

While the following isn't related to the current patch, I'd like to make a 
clear point about adding new methods/APIs for pure testability purposes.

If any new public methods are have to be introduce to facilitate the testing 
efforts then such methods ought to be add by the means of existing injection 
framework (see my comment on MAPREDUCE-1050) and not to be made a permanent 
addition to the production code.

> Add unit tests 
> ---------------
>
>                 Key: HDFS-669
>                 URL: https://issues.apache.org/jira/browse/HDFS-669
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: HDFS669.patch
>
>
> Most HDFS tests are functional tests that test a feature end to end by 
> running a mini cluster. We should add more tests like TestReplication that 
> attempt to stress individual classes in isolation, ie by stubbing out 
> dependencies without running a mini cluster. This allows for more fine-grain 
> testing and making tests run much more quickly because they avoid the cost of 
> cluster setup and teardown. If it makes sense to use another framework 
> besides junit we should standardize with MAPREDUCE-1050. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to