[
https://issues.apache.org/jira/browse/HDFS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769294#action_12769294
]
Suresh Srinivas commented on HDFS-654:
--------------------------------------
I have made all the changes suggested. Here are my comments:
> 1. FSNamesystem.renameTo() should not be public.
Currently all methods called from NameNode are public. I followed the same
pattern. I have change renameTo methods both old and new to package private.
> 5. Is OIV will be able to read new rename edit log records? Just adding the
> new supported version probably does not fix the reading problem by itself.
Per Jakob, the OIV reads FSImage only and not edit log. It needs to know all
the supported versions. Without updating it, it will not load the FSImage with
the new version.
> HDFS needs to support new rename introduced for FileContext
> -----------------------------------------------------------
>
> Key: HDFS-654
> URL: https://issues.apache.org/jira/browse/HDFS-654
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: 0.21.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-654.1.patch, hdfs-654.2.patch, hdfs-654.3.patch,
> hdfs-654.5.patch, hdfs-654.5.patch, hdfs-654.7.patch, HDFS-654.patch
>
>
> New rename functionality with different semantics to overwrite the existing
> destination was introduced for use in FileContext. Currently the default
> implementation in FileSystem is not atomic. This change implements atomic
> rename operation for use by FileContext.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
