[
https://issues.apache.org/jira/browse/HDFS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Shao updated HDFS-611:
----------------------------
Attachment: HDFS-611.branch-19.v2.patch
Made 2 changes:
# Follow the approach A4 above for the lock
# Removed the used imports
Regarding the other comments:
1. Most of the classes in DataNode are named Block* although some of them
represent a replica as well. From consistency point of view, it seems to me
BlockFileDeleter is a better name.
2. I think it still makes sense to limit the number of block invalidation
requests per heartbeat. We don't want a single heartbeat to be too big. I agree
the limit can set to something much bigger, e.g. 1000 or 5000.
3. I like the abstraction of creating a task using the 5 arguments, and then do
"execute(Task)". This makes it easy to add new fields to the Task. Also it
mimics the ThreadPoolExecutor.execute(...) function which makes it clearer that
the operation is asynchronous.
> Heartbeats times from Datanodes increase when there are plenty of blocks to
> delete
> ----------------------------------------------------------------------------------
>
> Key: HDFS-611
> URL: https://issues.apache.org/jira/browse/HDFS-611
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.1, 0.21.0, 0.22.0
> Reporter: dhruba borthakur
> Assignee: Zheng Shao
> Fix For: 0.20.2, 0.21.0, 0.22.0
>
> Attachments: HDFS-611.branch-19.patch, HDFS-611.branch-19.v2.patch,
> HDFS-611.branch-20.patch, HDFS-611.branch-20.v2.patch, HDFS-611.trunk.patch,
> HDFS-611.trunk.v2.patch
>
>
> I am seeing that when we delete a large directory that has plenty of blocks,
> the heartbeat times from datanodes increase significantly from the normal
> value of 3 seconds to as large as 50 seconds or so. The heartbeat thread in
> the Datanode deletes a bunch of blocks sequentially, this causes the
> heartbeat times to increase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
