[ https://issues.apache.org/jira/browse/HDFS-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HDFS-775: -------------------------------- Attachment: HDFS-775-1.patch This is a patch for this; I am using this defect to understand how to work with git/github for patches, so apologies if it does not apply properly - the path looks odd and may need a -p1 to take > FSDataset calls getCapacity() twice -bug? > ----------------------------------------- > > Key: HDFS-775 > URL: https://issues.apache.org/jira/browse/HDFS-775 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node > Affects Versions: 0.22.0 > Reporter: Steve Loughran > Priority: Minor > Attachments: HDFS-775-1.patch > > > I'm not sure this is a bug or "as intended", but I thought I'd mention it. > FSDataset.getCapacity() calls DF.getCapacity() twice, when evaluating its > capacity. Although there is caching to stop the shell being exec'd twice in a > row, there is a risk that the first call doesn't run the shell, and the > second does -so the value changes during the method. > If that is not intended, it is better to cache the first value for the whole > method -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.