[ https://issues.apache.org/jira/browse/HDFS-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789009#action_12789009 ]
Jakob Homan commented on HDFS-823: ---------------------------------- Looks like Hudson is falling down on the job again. Manual test-patch: {noformat}[exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.{noformat} No tests as explained above. Tests all pass locally except known-bad TestHDFSTrash. Will commit to trunk and 21. > In Checkpointer the getImage servlet is added to public rather than internal > servlet list > ----------------------------------------------------------------------------------------- > > Key: HDFS-823 > URL: https://issues.apache.org/jira/browse/HDFS-823 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Jakob Homan > Assignee: Jakob Homan > Attachments: HDFS-823.patch > > > Checkpointer.java:99 > {code} > httpServer.addServlet("getimage", "/getimage", > GetImageServlet.class);{code} > This should be addInternalServlet, as it is for Namenode to ensure this > servlet does not get filtered. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.