[ https://issues.apache.org/jira/browse/HDFS-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798212#action_12798212 ]
Hairong Kuang commented on HDFS-877: ------------------------------------ The change looks good to me. > I think we should also open another JIRA to directly test BlockReader and > ensure that CHECKSUM_OK gets sent in the various cases. Why don't we just add a few test cases to TestDatanodeblockScanner#testDatanodeBlocksacnner in the patch to this jira? Anyway we need unit tests to get this fix committed. > Client-driven block verification not functioning > ------------------------------------------------ > > Key: HDFS-877 > URL: https://issues.apache.org/jira/browse/HDFS-877 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client, test > Affects Versions: 0.20.1, 0.21.0, 0.22.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Blocker > Attachments: hdfs-877.txt, hdfs-877.txt, hdfs-877.txt > > > This is actually the reason for HDFS-734 (TestDatanodeBlockScanner timing > out). The issue is that DFSInputStream relies on readChunk being called one > last time at the end of the file in order to receive the > lastPacketInBlock=true packet from the DN. However, DFSInputStream.read > checks pos < getFileLength() before issuing the read. Thus gotEOS never > shifts to true and checksumOk() is never called. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.