[ 
https://issues.apache.org/jira/browse/HDFS-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803803#action_12803803
 ] 

Owen O'Malley commented on HDFS-905:
------------------------------------

This is looking good. I notice that you have some spurious whitespace changes 
and a fair number of lines that go past 80 characters.

In FileChecksumServlets.java, you have:

{noformat}
+        final NameNode namenode = getUGI(request).doAs(new PrivilegedExceptionA
ction<NameNode>() {
+          @Override
+          public NameNode run() throws IOException {
+            return (NameNode)context.getAttribute("name.node");
+          }
+        });
{noformat}

but the context.getAttribute doesn't use the current user, it just pulls an 
object out of a map setup when the jetty server started.



> Make changes to HDFS for the new UserGroupInformation APIs (HADOOP-6299)
> ------------------------------------------------------------------------
>
>                 Key: HDFS-905
>                 URL: https://issues.apache.org/jira/browse/HDFS-905
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Devaraj Das
>            Assignee: Jakob Homan
>             Fix For: 0.22.0
>
>         Attachments: HDFS-905.patch
>
>
> This is about moving the HDFS code to use the new UserGroupInformation API as 
> described in HADOOP-6299.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to