[
https://issues.apache.org/jira/browse/HDFS-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806644#action_12806644
]
Hadoop QA commented on HDFS-914:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431846/hdfs-914.txt
against trunk revision 903906.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 42 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/214/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/214/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/214/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/214/console
This message is automatically generated.
> Refactor DFSOutputStream and DFSInputStream out of DFSClient
> ------------------------------------------------------------
>
> Key: HDFS-914
> URL: https://issues.apache.org/jira/browse/HDFS-914
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-914.txt, hdfs-914.txt
>
>
> I'd like to propose refactoring DFSClient to extract DFSOutputStream and
> DFSInputStream into a new org.apache.hadoop.hdfs.client package. DFSClient
> has become unmanageably large, containing 8 inner classes.and approaching
> 4kloc. Factoring out the non-static inner classes will also make them easier
> to test in isolation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
