[
https://issues.apache.org/jira/browse/HDFS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828332#action_12828332
]
Hairong Kuang commented on HDFS-245:
------------------------------------
Eli, great work! A couple of more comments:
1. INodeSymlink extends INodeFile in your patch. Should it extend INode?
2. Should FSDirectory#mkdirs, rootDir.getExistingPathINodes(components, inodes,
true) be rootDir.getExistingPathINodes(components, inodes, false)? Mkdirs does
not need to resolve the symlink of the last component.
3. Your document does not discuss the symlink resolution of concat, setQuoto,
and getContentSummary etc. Could you please add them?
> Create symbolic links in HDFS
> -----------------------------
>
> Key: HDFS-245
> URL: https://issues.apache.org/jira/browse/HDFS-245
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Attachments: 4044_20081030spi.java, designdocv1.txt, designdocv2.txt,
> designdocv3.txt, HADOOP-4044-strawman.patch, symlink-0.20.0.patch,
> symlink-25-hdfs.patch, symlink-26-hdfs.patch, symlink-26-hdfs.patch,
> symLink1.patch, symLink1.patch, symLink11.patch, symLink12.patch,
> symLink13.patch, symLink14.patch, symLink15.txt, symLink15.txt,
> symlink16-common.patch, symlink16-hdfs.patch, symlink16-mr.patch,
> symlink17-common.txt, symlink17-hdfs.txt, symlink18-common.txt,
> symlink19-common-delta.patch, symlink19-common.txt, symlink19-common.txt,
> symlink19-hdfs-delta.patch, symlink19-hdfs.txt, symlink20-common.patch,
> symlink20-hdfs.patch, symlink21-common.patch, symlink21-hdfs.patch,
> symlink22-common.patch, symlink22-hdfs.patch, symlink23-common.patch,
> symlink23-hdfs.patch, symlink24-hdfs.patch, symlink27-hdfs.patch,
> symlink28-hdfs.patch, symlink29-hdfs.patch, symlink29-hdfs.patch,
> symlink30-hdfs.patch, symlink31-hdfs.patch, symlink33-hdfs.patch,
> symlink35-hdfs.patch, symLink4.patch, symLink5.patch, symLink6.patch,
> symLink8.patch, symLink9.patch
>
>
> HDFS should support symbolic links. A symbolic link is a special type of file
> that contains a reference to another file or directory in the form of an
> absolute or relative path and that affects pathname resolution. Programs
> which read or write to files named by a symbolic link will behave as if
> operating directly on the target file. However, archiving utilities can
> handle symbolic links specially and manipulate them directly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
