[ 
https://issues.apache.org/jira/browse/HDFS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837071#action_12837071
 ] 

dhruba borthakur commented on HDFS-729:
---------------------------------------

Code looks good. A few comments:

1. TestDFSClientRetries.java, you do not need to import java.util.Map
2. ClientProtocol javadocs still say "@return Map from FileStatus to 
LocatedBlocks object with locations of   * corrupted blocks.".
3. BlockManager.getCorruptInodes() returns a map of Inodes to BlockList. 
Instead, won't it be sufficient to return just a list of INodes?


> fsck option to list only corrupted files
> ----------------------------------------
>
>                 Key: HDFS-729
>                 URL: https://issues.apache.org/jira/browse/HDFS-729
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: dhruba borthakur
>            Assignee: Rodrigo Schmidt
>         Attachments: badFiles.txt, badFiles2.txt, corruptFiles.txt, 
> HDFS-729.1.patch, HDFS-729.2.patch
>
>
> An option to fsck to list only corrupted files will be very helpful for 
> frequent monitoring.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to