[ https://issues.apache.org/jira/browse/HDFS-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839021#action_12839021 ]
Todd Lipcon commented on HDFS-1001: ----------------------------------- Testing this is a bit difficult. I think the one _very_ important test is the negative test - ie that we don't end up calling datanode.blockScanner.verifiedByClient() for a partial read. I think you could add this as another test case in TestClientBlockVerification - just like testCompletePartialRead, except also replace the datanode.blockScanner with a spy and verify that verifiedByClient is *not* called for the partial read. > DataXceiver and BlockReader disagree on when to send/recv CHECKSUM_OK > --------------------------------------------------------------------- > > Key: HDFS-1001 > URL: https://issues.apache.org/jira/browse/HDFS-1001 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.22.0 > Reporter: bc Wong > > Running the TestPread with additional debug statements reveals that the > BlockReader sends CHECKSUM_OK when the DataXceiver doesn't expect it. > Currently it doesn't matter since DataXceiver closes the connection after > each op, and CHECKSUM_OK is the last thing on the wire. But if we want to > cache connections, they need to agree on the exchange of CHECKSUM_OK. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.