[ 
https://issues.apache.org/jira/browse/HDFS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839098#action_12839098
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-994:
---------------------------------------------

+1 patch looks good.  Minor suggestions:
- The InputStream in (or dis) in getDTfromRemote(..) is not closed.
- You may use java.lang.Void instead of Object in the generic type of 
PrivilegedExceptionAction
{code}
+      ugi.doAs(new PrivilegedExceptionAction<Object>() {
{code}
- ugiFinal can be eliminated by 
{code}
+    final UserGroupInformation ugi;
+    try {
+      ugi = getUGI(req);
+    } catch(IOException ioe) {
{code}

> Provide methods for obtaining delegation token from Namenode for hftp and 
> other uses
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-994
>                 URL: https://issues.apache.org/jira/browse/HDFS-994
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: HDFS-994-2.patch, HDFS-994-3.patch, HDFS-994.patch
>
>
> In hftp, destination clusters will require an RPC-version-agnostic means of 
> obtaining delegation tokens from the source cluster. The easiest method is 
> provide a webservice to retrieve a token over http.  This can be encrypted 
> via SSL (backed by Kerberos, done in another JIRA), providing security for 
> cross-cluster hftp operations.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to