[
https://issues.apache.org/jira/browse/HDFS-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845239#action_12845239
]
Rodrigo Schmidt commented on HDFS-1032:
---------------------------------------
André, thanks for working on this patch.
I agree with Dhruba's comments. Besides that, the changes look quite good. I
have just a few comments regarding code structure in general.
Your patch breaks indentation in a very bad way inside the "public void fsck()"
method (hunks 5-6).
If I were you I would just add the following to the beginning of the method:
{code}
if (showCorruptedFiles) {
showCorruptedFiles();
return;
}
{code}
You are not following the Apache spacing and indentation conventions. There are
a number of "}else{", "if(condition){", and some indentation problems.
Please use 2 spaces for indentation.
> Extend DFSck with an option to list corrupt files using API from HDFS-729
> -------------------------------------------------------------------------
>
> Key: HDFS-1032
> URL: https://issues.apache.org/jira/browse/HDFS-1032
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: tools
> Reporter: Rodrigo Schmidt
> Attachments: hdfs-1032_aoriani.patch
>
>
> HDFS-729 created a new API to namenode that returns the list of corrupt files.
> We can now extend fsck (DFSck.java) to add an option (e.g. --list_corrupt)
> that queries the namenode using the new API and lists the corrupt blocks to
> the users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
