[ 
https://issues.apache.org/jira/browse/HDFS-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854168#action_12854168
 ] 

Srikanth Sundarrajan commented on HDFS-482:
-------------------------------------------

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no new tests are needed 
for this patch.
     [exec]                         Also please list what manual steps were 
performed to verify this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.

Tests not included for this patch. Patch is fairly simple and reads the ssl 
conf from ssl-client.xml instead of the conf object.


> change HsftpFileSystem's ssl.client.do.not.authenticate.server configuration 
> setting to ssl-client.xml  
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-482
>                 URL: https://issues.apache.org/jira/browse/HDFS-482
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: contrib/hdfsproxy
>    Affects Versions: 0.22.0
>         Environment: currently this config setting can only be set by hdfs's 
> configuration files, need to move this setting to ssl-client.xml.
>            Reporter: zhiyong zhang
>            Assignee: Srikanth Sundarrajan
>             Fix For: 0.22.0
>
>         Attachments: HDFS-482.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to