[ https://issues.apache.org/jira/browse/HDFS-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861026#action_12861026 ]
Konstantin Boudnik commented on HDFS-921: ----------------------------------------- Handling imports automatically is a good thing: stale imports are being eliminated and all that. Actually, I was about to suggest to move this test into src/test/unit because now it looks like a real unit test. Shall I open a separate JIRA for that? What do you think? > Convert TestDFSClientRetries::testNotYetReplicatedErrors to Mockito > ------------------------------------------------------------------- > > Key: HDFS-921 > URL: https://issues.apache.org/jira/browse/HDFS-921 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test > Reporter: Jakob Homan > Assignee: Jakob Homan > Fix For: 0.22.0 > > Attachments: HDFS-921-2.patch, HDFS-921.patch > > > When TestDFSClientRetries::testNotYetReplicatedErrors was written, Mockito > was not available and the NameNode was mocked by manually extending > ClientProtocol and implementing all the methods, most with empty bodies. Now > that we have Mockito, this code can be removed and replaced with an actual > mock. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.