[
https://issues.apache.org/jira/browse/HDFS-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864627#action_12864627
]
Hadoop QA commented on HDFS-1028:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12443789/HDFS-split.2.patch
against trunk revision 939918.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/346/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/346/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/346/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/346/console
This message is automatically generated.
> INode.getPathNames could split more efficiently
> -----------------------------------------------
>
> Key: HDFS-1028
> URL: https://issues.apache.org/jira/browse/HDFS-1028
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Todd Lipcon
> Assignee: Dmytro Molkov
> Priority: Minor
> Attachments: HDFS-split.2.patch, HDFS-split.patch
>
>
> INode.getPathnames uses String.split(String) which actually uses the full
> Java regex implementation. Since we're always splitting on a single char, we
> could implement a faster one like StringUtils.split() (except without the
> escape character). This takes a significant amount of CPU during FSImage
> loading so should be a worthwhile speedup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
