[
https://issues.apache.org/jira/browse/HDFS-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866115#action_12866115
]
Hadoop QA commented on HDFS-970:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12444191/hdfs-970.txt
against trunk revision 942863.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/353/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/353/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/353/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/353/console
This message is automatically generated.
> FSImage writing should always fsync before close
> ------------------------------------------------
>
> Key: HDFS-970
> URL: https://issues.apache.org/jira/browse/HDFS-970
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Attachments: hdfs-970.txt
>
>
> Without an fsync, it's common that filesystems will delay the writing of
> metadata to the journal until all of the data blocks have been flushed. If
> the system crashes while the dirty pages haven't been flushed, the file is
> left in an indeterminate state. In some FSs (eg ext4) this will result in a
> 0-length file. In others (eg XFS) it will result in the correct length but
> any number of data blocks getting zeroed. Calling FileChannel.force before
> closing the FSImage prevents this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
