[ https://issues.apache.org/jira/browse/HDFS-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1119: ----------------------------------------- Attachment: h1119_20100525.patch Thanks Konstantin for the comments. h1119_20100525.patch: - Renamed GettableSet* to GSet*. - Changed GSet<E> to GSet<K, E>. > On the patch itself, it would be good to put a comment after @Override > indicating which class it actually overrides. Simplifies life. I did not make this change since it is very easy to see the class it overrides by Eclipse or some other IDEs. > Refactor BlocksMap with GettableSet > ----------------------------------- > > Key: HDFS-1119 > URL: https://issues.apache.org/jira/browse/HDFS-1119 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node > Reporter: Tsz Wo (Nicholas), SZE > Attachments: h1119_20100429.patch, h1119_20100506.patch, > h1119_20100521.patch, h1119_20100525.patch > > > The data structure required in BlocksMap is a GettableSet. See also [this > comment|https://issues.apache.org/jira/browse/HDFS-1114?focusedCommentId=12862118&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12862118]. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.