[ 
https://issues.apache.org/jira/browse/HDFS-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183585#comment-14183585
 ] 

Colin Patrick McCabe commented on HDFS-7173:
--------------------------------------------

{code}
    /** The unchanged locations that are existed in the old configuration */
{code}
Should be "the unchanged locations that exist in the old configuration"

There's a whitepsace change in DataNode.java that isn't necessary, can we 
remove that?

+1 once those are addressed.

> Only keep successfully loaded volumes in the configuration.
> -----------------------------------------------------------
>
>                 Key: HDFS-7173
>                 URL: https://issues.apache.org/jira/browse/HDFS-7173
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: 3.0.0, 2.6.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HDFS-7173.000.combo.patch, HDFS-7173.000.patch, 
> HDFS-7173.001.combo.patch, HDFS-7173.001.patch, HDFS-7173.002.combo.patch, 
> HDFS-7173.002.patch
>
>
> Hot swapping data volumes might fail. The user should be able to fix the 
> failed volumes and disks, then ask the {{DataNode}} to retry the previously 
> failed volumes. 
> To attempt to reload the failed volume again on the same directory, this 
> failed directory must not be presented in the {{Configuration}} object that 
> {{DataNode has}}. Therefore, it should only put successfully loaded volumes 
> into the {{Configuration}} object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to