[ https://issues.apache.org/jira/browse/HDFS-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186086#comment-14186086 ]
Hadoop QA commented on HDFS-7291: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12677405/HDFS-7291.2.patch against trunk revision 5b1dfe7. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 13 warning messages. See https://builds.apache.org/job/PreCommit-HDFS-Build/8554//artifact/patchprocess/diffJavadocWarnings.txt for details. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles org.apache.hadoop.hdfs.server.balancer.TestBalancer org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles org.apache.hadoop.hdfs.TestDFSClientRetries The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation org.apache.hadoop.hdfs.TestFileAppend4 {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8554//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8554//console This message is automatically generated. > Persist in-memory replicas with appropriate unbuffered copy API on POSIX and > Windows > ------------------------------------------------------------------------------------ > > Key: HDFS-7291 > URL: https://issues.apache.org/jira/browse/HDFS-7291 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode > Affects Versions: 2.6.0 > Reporter: Xiaoyu Yao > Assignee: Xiaoyu Yao > Attachments: HDFS-7291.0.patch, HDFS-7291.1.patch, HDFS-7291.2.patch > > > HDFS-7090 changes to persist in-memory replicas using unbuffered IO on Linux > and Windows. On Linux distribution, it relies on the sendfile() API between > two file descriptors to achieve unbuffered IO copy. According to Linux > document at http://man7.org/linux/man-pages/man2/sendfile.2.html, this is > only supported on Linux kernel 2.6.33+. > As pointed by Haowei in the discussion below, FileChannel#transferTo already > has support for native unbuffered IO on POSIX platform. On Windows, JDK 6/7/8 > has not implemented native unbuffered IO yet. We change to use > FileChannel#transfer for POSIX and our own native wrapper of CopyFileEx on > Windows for unbuffered copy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)