[
https://issues.apache.org/jira/browse/HDFS-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189175#comment-14189175
]
Yongjun Zhang commented on HDFS-7281:
-------------------------------------
HI [~mingma],
Thanks for addressing my comments, the change looks good to me.
About the test failure, I used the tool from HADOOP-11045 and found the
following:
{code}
****Recently FAILED builds in url:
https://builds.apache.org//job/PreCommit-Hdfs-Build
THERE ARE 95 builds (out of 100) that have failed tests in the past 7 days,
as listed below:
......
Among 100 runs examined, all failed tests <#failedRuns: testName>:
6: org.apache.hadoop.hdfs.TestLeaseRecovery2.testLeaseRecoverByAnotherUser
6: org.apache.hadoop.hdfs.TestLeaseRecovery2.testHardLeaseRecovery
6:
org.apache.hadoop.hdfs.TestLeaseRecovery2.testHardLeaseRecoveryWithRenameAfterNameNodeRestart
5: org.apache.hadoop.hdfs.server.balancer.TestBalancer.testUnknownDatanode
5: org.apache.hadoop.hdfs.TestLeaseRecovery2.testThreadName
3: org.apache.hadoop.hdfs.TestDFSClientRetries.testFailuresArePerOperation
...
{code}
So the TestLeaseReovery2 is not relevant to your change as we expected.
I suggest that you run locally both the this test and the timeouted one
TestEncryptionZonesWithHA and see if they pass with your patch, for
completeness.
Thanks.
> Missing block is marked as corrupted block
> ------------------------------------------
>
> Key: HDFS-7281
> URL: https://issues.apache.org/jira/browse/HDFS-7281
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ming Ma
> Assignee: Ming Ma
> Attachments: HDFS-7281-2.patch, HDFS-7281.patch
>
>
> In the situation where the block lost all its replicas, fsck shows the block
> is missing as well as corrupted. Perhaps it is better not to mark the block
> corrupted in this case. The reason it is marked as corrupted is
> numCorruptNodes == numNodes == 0 in the following code.
> {noformat}
> BlockManager
> final boolean isCorrupt = numCorruptNodes == numNodes;
> {noformat}
> Would like to clarify if it is the intent to mark missing block as corrupted
> or it is just a bug.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
