[ 
https://issues.apache.org/jira/browse/HDFS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196334#comment-14196334
 ] 

Suresh Srinivas commented on HDFS-7340:
---------------------------------------

+1 for the patch. Couple of comments:
bq. upgrade has been finalized
Can you please change this to "upgrade already has been finalized"?

Also please add Idempotent annotation to the method.


> make rollingUpgrade start/finalize idempotent
> ---------------------------------------------
>
>                 Key: HDFS-7340
>                 URL: https://issues.apache.org/jira/browse/HDFS-7340
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha
>    Affects Versions: 2.4.0
>            Reporter: Arpit Gupta
>            Assignee: Jing Zhao
>         Attachments: HDFS-7340.000.patch
>
>
> I was running this on a HA cluster with 
> dfs.client.test.drop.namenode.response.number set to 1. So the first request 
> goes through but the response is dropped. Which then causes another request 
> which fails and says a request is already in progress. We should add retry 
> cache support for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to