[ 
https://issues.apache.org/jira/browse/HDFS-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201030#comment-14201030
 ] 

Aaron T. Myers commented on HDFS-7331:
--------------------------------------

bq. Is there a reason to make it configurable? Maybe we can first experiment 
with a reasonable default value, and make it configurable later.

Sorry, let me ask again: why are we making this map have a max size at all? I 
can't think of any good reason to do so, and I can think of some bad ones - 
specifically that this will be used to try to diagnose network issues, and 
having the possibility of an incomplete view of the failures is not good at all 
for this purpose.

If you insist on it having an enforceable max size, then it absolutely should 
be configurable, and the default value should be very high IMO - maybe 5,000 - 
which should cover almost all clusters in the world.

> Add Datanode network counts to datanode jmx page
> ------------------------------------------------
>
>                 Key: HDFS-7331
>                 URL: https://issues.apache.org/jira/browse/HDFS-7331
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Charles Lamb
>            Assignee: Charles Lamb
>            Priority: Minor
>         Attachments: HDFS-7331.001.patch, HDFS-7331.002.patch
>
>
> Add per-datanode counts to the datanode jmx page. For example, networkErrors 
> could be exposed like this:
> {noformat}
>   }, {
> ...
>     "DatanodeNetworkCounts" : "{\"dn1\":{\"networkErrors\":1}}",
> ...
>     "NamenodeAddresses" : 
> "{\"localhost\":\"BP-1103235125-127.0.0.1-1415057084497\"}",
>     "VolumeInfo" : 
> "{\"/tmp/hadoop-cwl/dfs/data/current\":{\"freeSpace\":3092725760,\"usedSpace\":28672,\"reservedSpace\":0}}",
>     "ClusterId" : "CID-4b38f2ae-5e58-4e15-b3cf-3ba3f46e724e"
>   }, {
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to