[
https://issues.apache.org/jira/browse/HDFS-7279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14211697#comment-14211697
]
Tsz Wo Nicholas Sze commented on HDFS-7279:
-------------------------------------------
> ... Calling releaseDfsResources() in exceptionCaught() and channelInactive()
> is sufficient.
I see. BTW, we should remove "throws Exception" from exceptionCaught() and
channelInactive().
Some other comments:
- There are a lot of hardcoded strings/values. We should use predefined
constants.
-* Please use WebHdfsFileSystem.PATH_PREFIX for "/webhdfs/v1" and
PATH_PREFIX.length() for 11.
-* For http headers, use io.netty.handler.codec.http.HttpHeaders.Names/Values.
-* For WebHDFS constants use the classes in
org.apache.hadoop.hdfs.web.resources, e.g. use GetOpParam.Op.GETFILECHECKSUM
for "GETFILECHECKSUM".
- There are unused imports in ParameterParser.
> Use netty to implement DatanodeWebHdfsMethods
> ---------------------------------------------
>
> Key: HDFS-7279
> URL: https://issues.apache.org/jira/browse/HDFS-7279
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, webhdfs
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-7279.000.patch, HDFS-7279.001.patch,
> HDFS-7279.002.patch, HDFS-7279.003.patch, HDFS-7279.004.patch,
> HDFS-7279.005.patch, HDFS-7279.006.patch, HDFS-7279.007.patch,
> HDFS-7279.008.patch, HDFS-7279.009.patch
>
>
> Currently the DN implements all related webhdfs functionality using jetty. As
> the current jetty version the DN used (jetty 6) lacks of fine-grained buffer
> and connection management, DN often suffers from long latency and OOM when
> its webhdfs component is under sustained heavy load.
> This jira proposes to implement the webhdfs component in DN using netty,
> which can be more efficient and allow more finer-grain controls on webhdfs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
