[ 
https://issues.apache.org/jira/browse/HDFS-7415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219872#comment-14219872
 ] 

Charles Lamb commented on HDFS-7415:
------------------------------------

Hi [~wheat9],

Thanks for working on this. I have a few more nits:

I was under the impression that wildcard imports are not in the coding 
standards?

Somehow an extra newline snuck into the comment for resolvePath right before 
the param pc. While you're in there, you might want to s/pathComponents/path 
Components".

"has super user privs." -> "has super user privileges."

As Suresh said, +1 (non-binding) pending Jenkins.

> Move FSNameSystem.resolvePath() to FSDirectory
> ----------------------------------------------
>
>                 Key: HDFS-7415
>                 URL: https://issues.apache.org/jira/browse/HDFS-7415
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-7415.000.patch, HDFS-7415.001.patch
>
>
> It would be nice to move {{resolvePath()}} to {{FSDirectory}} as the concept 
> belongs to {{FSDirectory}} and it is a simple wrapper for the calls in 
> {{FSDirectory}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to