[ https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225094#comment-14225094 ]
Jing Zhao commented on HDFS-7440: --------------------------------- The patch looks good to me. One small suggestion is that I think the changes related to audit log can be separated into another jira since it changes the current auditlog semantic. +1 after addressing the comments. > Consolidate snapshot related operations in a single class > --------------------------------------------------------- > > Key: HDFS-7440 > URL: https://issues.apache.org/jira/browse/HDFS-7440 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-7440.000.patch > > > Currently the snapshot-related code scatters across both {{FSNameSystem}} and > {{FSDirectory}}. This jira proposes to consolidate the logic in a single > class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)