[ 
https://issues.apache.org/jira/browse/HDFS-7023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225548#comment-14225548
 ] 

Zhanwei Wang commented on HDFS-7023:
------------------------------------

Hi [~cmccabe]

The patch looks good. But the compiler failed build the binary. 

{code}

Undefined symbols for architecture x86_64:
  "_XML_ErrorString", referenced from:
      hdfs::internal::XmlConfigParser::ParseXml(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&) in 
XmlConfigParser.cc.o
  "_XML_GetCurrentLineNumber", referenced from:
      hdfs::internal::XmlData::endElement(void*, char const*) in 
XmlConfigParser.cc.o
      hdfs::internal::XmlData::handleData(void*, char const*, int) in 
XmlConfigParser.cc.o
  "_XML_GetErrorCode", referenced from:
      hdfs::internal::XmlConfigParser::ParseXml(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&) in 
XmlConfigParser.cc.o
  "_XML_Parse", referenced from:
      hdfs::internal::XmlConfigParser::ParseXml(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&) in 
XmlConfigParser.cc.o
  "_XML_ParserCreate", referenced from:
      hdfs::internal::XmlConfigParser::ParseXml(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&) in 
XmlConfigParser.cc.o
  "_XML_ParserFree", referenced from:
      hdfs::internal::XmlData::~XmlData() in XmlConfigParser.cc.o
  "_XML_SetCharacterDataHandler", referenced from:
      hdfs::internal::XmlData::XmlData(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, 
XML_ParserStruct*) in XmlConfigParser.cc.o
  "_XML_SetElementHandler", referenced from:
      hdfs::internal::XmlData::XmlData(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, 
XML_ParserStruct*) in XmlConfigParser.cc.o
  "_XML_SetUserData", referenced from:
      hdfs::internal::XmlData::XmlData(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, 
XML_ParserStruct*) in XmlConfigParser.cc.o
  "hdfs::internal::StrToInt32(char const*, int*)", referenced from:
      hdfs::Config::getInt32(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, int*) const in 
Config.cc.o
      hdfs::Config::getInt32(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, int*) 
const in Config.cc.o
  "hdfs::internal::StrToInt64(char const*, long long*)", referenced from:
      hdfs::Config::getInt64(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, long long*) 
const in Config.cc.o
      hdfs::Config::getInt64(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, long long, 
long long*) const in Config.cc.o
  "hdfs::internal::StrToDouble(char const*, double*)", referenced from:
      hdfs::Config::getDouble(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, double*) const 
in Config.cc.o
      hdfs::Config::getDouble(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, double, 
double*) const in Config.cc.o
  "hdfs::internal::StrToBool(char const*, bool*)", referenced from:
      hdfs::Config::getBool(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool*) const 
in Config.cc.o
      hdfs::Config::getBool(std::__1::basic_string<char, 
std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, bool*) 
const in Config.cc.o
      hdfs::internal::XmlData::handleData(void*, char const*, int) in 
XmlConfigParser.cc.o

{code}

Seems that you forget to modify CMake file to add libexpat.

> use libexpat instead of libxml2 for libhdfs3
> --------------------------------------------
>
>                 Key: HDFS-7023
>                 URL: https://issues.apache.org/jira/browse/HDFS-7023
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Zhanwei Wang
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-7023.001.pnative.patch
>
>
> As commented in HDFS-6994, libxml2 may has some thread safe issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to