[ 
https://issues.apache.org/jira/browse/HDFS-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230809#comment-14230809
 ] 

Andrew Wang commented on HDFS-7446:
-----------------------------------

Nice. I like the style of this patch. All I've got is nitty stuff, +1 pending.

* Javadoc on ClientProtocol#getEditsFromTxid could use a small update to say 
"list of batches of events"
* Would rather just say "old" rather than "pre-2.7" in the exception message, 
since I'm not sure what's going into 2.7 yet. Arun might just take 2.6, add 
JDK7, and release that as 2.7.

> HDFS inotify should have the ability to determine what txid it has read up to
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-7446
>                 URL: https://issues.apache.org/jira/browse/HDFS-7446
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: dfsclient
>    Affects Versions: 2.6.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-7446.001.patch, HDFS-7446.002.patch
>
>
> HDFS inotify should have the ability to determine what txid it has read up 
> to.  This will allow users who want to avoid missing any events to record 
> this txid and use it to resume reading events at the spot they left off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to