[ 
https://issues.apache.org/jira/browse/HDFS-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232100#comment-14232100
 ] 

Chris Nauroth commented on HDFS-7188:
-------------------------------------

I agree with the direction of using separately compiled platform-specific files 
over lots of ifdefs (something that we're unfortunately still maintaining on 
the libhadoop.so/hadoop.dll side).

[~thanhdo], you might want to review the libhdfs patch I committed for 
HDFS-573.  I believe this was the first time we split Windows code into 
separate files.  I ran into similar issues to what you described: different 
parameter orders, different signatures on the printf family of functions, and 
missing functions.  The HDFS-573 patch almost entirely avoided ifdefs by using 
a set of common headers, platform-specific implementation files grouped under 
separate directories, and some indirection with macros and typedefs.  Maybe 
looking at this prior patch will demonstrate techniques that you can use here.

> support build libhdfs3 on windows
> ---------------------------------
>
>                 Key: HDFS-7188
>                 URL: https://issues.apache.org/jira/browse/HDFS-7188
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>         Environment: Windows System, Visual Studio 2010
>            Reporter: Zhanwei Wang
>            Assignee: Thanh Do
>         Attachments: HDFS-7188-branch-HDFS-6994-0.patch
>
>
> libhdfs3 should work on windows



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to