[ 
https://issues.apache.org/jira/browse/HDFS-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232576#comment-14232576
 ] 

Haohui Mai commented on HDFS-7468:
----------------------------------

{code}
!fsd.getFSNamesystem().isImageLoaded()
{code}

Maybe it makes more sense to expose {{isImageLoaded()}} instead of 
{{FSNamesystem}} in the interface. Other than that the patch looks pretty good 
to me.

> Code cleanup for verify* in FSDirectory
> ---------------------------------------
>
>                 Key: HDFS-7468
>                 URL: https://issues.apache.org/jira/browse/HDFS-7468
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: HDFS-7468-120214-1.patch, HDFS-7468-120214.patch
>
>
> We need to clean up verify* methods in FSDirectory. It would be cleaner if 
> those methods are close to their call sites. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to