[ https://issues.apache.org/jira/browse/HDFS-7463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235195#comment-14235195 ]
Hadoop QA commented on HDFS-7463: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685182/HDFS-7463.002.patch against trunk revision 7896815. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestFsck org.apache.hadoop.hdfs.TestEncryptionZones org.apache.hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot org.apache.hadoop.hdfs.TestGetBlocks org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS org.apache.hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8914//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8914//console This message is automatically generated. > Simplify FSNamesystem#getBlockLocationsUpdateTimes > -------------------------------------------------- > > Key: HDFS-7463 > URL: https://issues.apache.org/jira/browse/HDFS-7463 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-7463.000.patch, HDFS-7463.001.patch, > HDFS-7463.002.patch, HDFS-7463.003.patch > > > Currently {{FSNamesystem#getBlockLocationsUpdateTimes}} holds the read lock > to access the blocks. It releases the read lock and then acquires the write > lock when it needs to update the access time of the {{INode}}. > This jira proposes to move the responsibility of the latter steps to the > caller to simplify the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)