[ https://issues.apache.org/jira/browse/HDFS-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239709#comment-14239709 ]
Hudson commented on HDFS-7473: ------------------------------ SUCCESS: Integrated in Hadoop-Hdfs-trunk #1967 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1967/]) HDFS-7473. Document setting dfs.namenode.fs-limits.max-directory-items to 0 is invalid. Contributed by Akira AJISAKA. (cnauroth: rev d555bb2120cb44d094546e6b6560926561876c10) * hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java > Document setting dfs.namenode.fs-limits.max-directory-items to 0 is invalid > --------------------------------------------------------------------------- > > Key: HDFS-7473 > URL: https://issues.apache.org/jira/browse/HDFS-7473 > Project: Hadoop HDFS > Issue Type: Bug > Components: documentation > Affects Versions: 2.4.0, 2.5.2 > Reporter: Jason Keller > Assignee: Akira AJISAKA > Labels: newbie > Fix For: 2.7.0 > > Attachments: HDFS-7473-001.patch > > > When setting dfs.namenode.fs-limits.max-directory-items to 0 in > hdfs-site.xml, the error "java.lang.IllegalArgumentException: Cannot set > dfs.namenode.fs-limits.max-directory-items to a value less than 0 or greater > than 6400000" is produced. However, the documentation shows that 0 is a > valid setting for dfs.namenode.fs-limits.max-directory-items, turning the > check off. > Looking into the code in > hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java > shows that the culprit is > Preconditions.checkArgument(maxDirItems > 0 && maxDirItems <= MAX_DIR_ITEMS, > "Cannot set "+ DFSConfigKeys.DFS_NAMENODE_MAX_DIRECTORY_ITEMS_KEY+ " to a > value less than 0 or greater than " + MAX_DIR_ITEMS); > This checks if maxDirItems is greater than 0. Since 0 is not greater than 0, > it produces an error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)